Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix zlib error of 'Error: unexpected end of file' #225

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix zlib error of 'Error: unexpected end of file' #225

wants to merge 2 commits into from

Conversation

JanzenZhangChen
Copy link

fix zlib error of 'Error: unexpected end of file'.

@JanzenZhangChen
Copy link
Author

now I have no idea how to fix this problem, couldnt pass the "on the nose" mocha test.

@monkpow
Copy link
Collaborator

monkpow commented May 10, 2017

Hey @JanzenZhangChen, thanks for the patch.

Quick glance at the tests shows:

  1) test userResDecorator on html response from github is able to read and manipulate the response:
     Error: incorrect header check
      at Zlib._handle.onerror (zlib.js:366:17)

Seems likely related to your patch. I'd like that to pass, and to have a test for this change to accept.

Let me know any questions, thanks!

@scr4bble
Copy link

scr4bble commented Apr 12, 2018 •
edited
Loading

Is this trying to fix the issue #177 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JanzenZhangChen @monkpow @scr4bble